fix: correct bug with repeated substation in TransformGrid._add_bus #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I caught it the hard way 😩 |
|
Where is the Exception raised when you add two buses at the same location? |
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix an Exception that's thrown when you add two new buses with the same coordinates.
What the code is doing
In
TransformGridthelatlon2subvariable holds a dictionary of{(lat, lon): list_of_substation_ids}. When we add a bus at a new location, we create a new substation, and we want to add its id to this lookup dict, but we had been adding it as an int, rather than a list containing that int.test_transform_grid is updated to check for this bug.
Testing
The unit test is updated to check for this bug, and after the fix all tests pass again.
Time estimate
2 minutes.